-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle undefined target
in SelectWidget's onBlur and onFocus
#3585
Conversation
target
in SelectWidget's onBlur and onFocus handlers
target
in SelectWidget's onBlur and onFocus handlerstarget
in SelectWidget's onBlur and onFocus
onBlur(id, enumOptionsValueForIndex<S>(target && target.value, enumOptions, optEmptyVal)); | ||
const _onFocus = (_: FocusEvent<HTMLElement>, { target }: DropdownProps) => | ||
onFocus(id, enumOptionsValueForIndex<S>(target && target.value, enumOptions, optEmptyVal)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only component that has this issue? Maybe the same change needs to be made for all of the other widgets that deal with onBlur/onFocus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into it.
@huyph I wondering when you'll get a chance to address my questions. Also you'll have to resolve conflicts now. |
Hi I am still having this problem with the newest version when I am utilizing semantic UI Theme. Is there any workaround? |
@hfjohn123 I'm not sure why @huyph closed this PR. If you want to pick up this fix and address the additional potential changes I encourage you to do so and open your own PR. |
Hi @heath-freenome, I accidentally closed this PR. Sorry for the confusion. I will try to get back to it within the next few weeks. Feel free to collaborate with me on this PR @hfjohn123 |
Hi @heath-freenome , any update on this P.R? as i am too facing this issue. Thanks! |
@ahmedsakri Maybe you'll need to collaborate with @huyph to get this fixed? |
@huyph Seems like this stalled? |
Closing in favor of #4227 |
Reasons for making this change
[Please describe them here]
When using the default SelectWidget from @rjsf/semantic-ui@5.5.0, I observed these errors from
SelectWidget.tsx
Checklist
npm run test:update
to update snapshots, if needed.